Re: [PATCH v2 22/22] builtin/diff: free symmetric diff members

From: karthik nayak <karthik.188@gmail.com>
Date: Aug 12, 2024, 09:12 UTC
Message-ID: <CAOLa=ZSjBxVxmr7xiOFk0+2N4sTuxq9pFZt4ytK=L9kyw=Zvig@mail.gmail.com>
In-Reply-To: <343ddcd17b3e13dc7b8ab89f9c9c427bb2ed101c.1723121979.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> We populate a `struct symdiff` in case the user has requested a
> symmetric diff. Part of this is to populate a `skip` bitmap that
> indicates whihc commits shall be ignored in the diff. But while this

s/whihc/which

Show 5 quoted lines

> bitmap is dynamically allocated, we never free it.
>
> Fix this by introducing and calling a new `symdiff_release()` function
> that does this for us.
>

[snip]

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.