Re: [PATCH v10 00/15] Upstreaming the Scalar command

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 9, 2021, 03:52 UTC
Message-ID: <xmqq8rwuv3i2.fsf@gitster.g>
In-Reply-To: <nycvar.QRO.7.76.6.2112081207320.90@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 8 quoted lines

> The Scalar Functional Tests were designed with Azure Repos in mind, i.e.
> they specifically verify that the `gvfs-helper` (emulating Partial Clone
> using the predecessor of Partial Clone, the GVFS protocol) manages to
> access the repositories in the intended way.
> ...
> I do realize, though, that clarity of intention has been missing from this
> mail thread all around, so let me ask point blank: Junio, do you want me
> to include upstreaming `gvfs-helper` in the overall Scalar plan?

Sorry, I do not follow.

What I was lamenting about was the lack of CI test coverage of stuff that is already being considered to go 'next'. Specifically, since contrib/scalar/Makefile in 'seen' has a 'test' target, it would be a shame not to exercise it, when we should be able to do so in the CI fairly easily.

I fail to see what gvfs-helper has to do with anything in the context of advancing the js/scalar topic as we have today. If "The Scalar Functional Tests" that were designed with Azure Repos in mind is not a good fit to come into contrib/scalar/, it is fine not to have it here---lack of it would not make the test target you have in contrib/scalar/Makefile any less valuable, I would think.

Unless you are saying that "make -C contrib/scalar test" is useless, that is. But I do not think that is the case.