Re: [PATCH 10/15] scalar: implement the `run` command
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Aug 31, 2021, 08:27 UTC
- Message-ID
- <877dg2xbjp.fsf@evledraar.gmail.com>
- In-Reply-To
- <c3f16bccd023601bb1d041c36cf5f49011abcb76.1630359290.git.gitgitgadget@gmail.com>
On Mon, Aug 30 2021, Derrick Stolee via GitGitGadget wrote:
> + const char *usagestr[] = { NULL, NULL };Missing usage strings?
> + if (argc == 0)
Style nit (per style guide): s/argc == 0/!argc/g.
> + if (!strcmp("all", argv[0]))
> + i = -1;Style nit (per style guide): missing braces here.
(Just noting the style nits once, but more in this patch, and presumably the rest of the series...)