Re: [PATCH v8 00/17] Upstreaming the Scalar command

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 23, 2021, 13:05 UTC
Message-ID: <nycvar.QRO.7.76.6.2111231403030.63@tvgsbejvaqbjf.bet>
In-Reply-To: <211123.86ee77uj18.gmgdl@evledraar.gmail.com>

Hi Ævar,

On Tue, 23 Nov 2021, Ævar Arnfjörð Bjarmason wrote:

Show 42 quoted lines

> On Tue, Nov 23 2021, Johannes Schindelin wrote:
>
> > Hi Ævar,
> >
> > On Tue, 23 Nov 2021, Ævar Arnfjörð Bjarmason wrote:
> >
> >> [...]
> >>     $ make clean; make -C contrib/scalar test
> >>     [...]
> >>         CC hook.o
> >>         CC version.o
> >>         CC help.o
> >>         AR libgit.a
> >>     make[1]: Leaving directory '/home/avar/g/git'
> >>         SUBDIR ../..
> >>     make[1]: Entering directory '/home/avar/g/git'
> >>         * new link flags
> >>         CC contrib/scalar/scalar.o
> >>         LINK contrib/scalar/scalar
> >>     make[1]: Leaving directory '/home/avar/g/git'
> >>     make -C t
> >>     make[1]: Entering directory '/home/avar/g/git/contrib/scalar/t'
> >>     *** prove ***
> >>     error: GIT-BUILD-OPTIONS missing (has Git been built?).
> >>     t9099-scalar.sh .. Dubious, test returned 1 (wstat 256, 0x100)
> >>     No subtests run
> >
> > That's cute. You seem to have missed that this is `contrib/`? The
> > assumption of pretty much _everything_ in there is that Git was already
> > built.
> >
> > Try this at home: `make clean && make -C contrib/subtree/ test`
> >
> > Yep. It "fails" in the same way. "has Git been built?".
> >
> > So if that was all the evidence in favor of that misinformation "Scalar's
> > build is broken! Broken, broken, BROKEN!", I think we can now let it rest.
> > At last.
>
> No, it doesn't fail in the same way. Really, it seems like you're either
> not fully reading through E-Mails before replying, or entirely
> misunderstanding what I'm saying.

That's really... fresh.

I told you half a dozen times that at this point, the build works well enough, and that what you keep insisting is a problem simply isn't.

Yes, you have to build Git before building Scalar.

Have you actually looked at the design of Scalar? What it does to allow working with large repositories?

_That_ is what counts.

That you are told to please build Git before running Scalar's tests is maybe a minor annoyance, but not worth the dozens of mails and the weeks of delay that you caused over this.

Ciao, Johannes