Re: [PATCH v10 00/15] Upstreaming the Scalar command
- From
Elijah Newren <newren@gmail.com>
- Date
- Dec 11, 2021, 05:15 UTC
- Message-ID
- <CABPp-BGt=AcCg-74SSpS7iPFOCKnWE7Q7+CruvALLxKnqXGRuw@mail.gmail.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.2112110044010.90@tvgsbejvaqbjf.bet>
Hi Dscho,
On Fri, Dec 10, 2021 at 4:29 PM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 34 quoted lines
> > Hi Junio, > > On Wed, 8 Dec 2021, Junio C Hamano wrote: > > > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > > > The Scalar Functional Tests were designed with Azure Repos in mind, i.e. > > > they specifically verify that the `gvfs-helper` (emulating Partial Clone > > > using the predecessor of Partial Clone, the GVFS protocol) manages to > > > access the repositories in the intended way. > > > ... > > > I do realize, though, that clarity of intention has been missing from this > > > mail thread all around, so let me ask point blank: Junio, do you want me > > > to include upstreaming `gvfs-helper` in the overall Scalar plan? > > > > Sorry, I do not follow. > > In > https://lore.kernel.org/git/CABPp-BGpe9Q5k22Yu8a=1xwu=pZYSeNQoqEgf+DN07cU4EB1ew@mail.gmail.com/ > (i.e. in the great great grand parent of this mail), you specifically > replied to my mentioning Scalar's Functional Test suite: > > > > One other thing is very interesting about that vfs-with-scalar > > > branch thicket: it contains a GitHub workflow which will run > > > Scalar's quite extensive Functional Tests suite. This test > > > suite is quite comprehensive and caught us a lot of bugs in > > > the past, not only in the Scalar code, but also core Git. > > > > From your wording it sounds like the plan might not include > > moving these tests over. Perhaps it doesn't make sense to move > > them all over, but since they've caught problems in both Scalar > > and core Git, it would be nice to see many of those tests come > > to Git as well as part of a future follow on series.
This is me and my email you are quoting; these aren't Junio's words. I'm afraid my confusion may have snowballed for others here. Sorry about that.
I simply misunderstood at the time -- I thought there were scalar-only tests (rather than scalar+gvfs tests) that were not being considered for upstreaming. As I mentioned before[1], I'm sorry for the confusion and seemingly opening an unrelated can of worms. I agree that we don't need gvfs tests, or tests that combine gvfs with other things like scalar, or c# tests.
[1] https://lore.kernel.org/git/CABPp-BFmNiqY=NfN7Ys3XE8wYBn1EQ_War+0QLq96Tk7FO6zfg@mail.gmail.com/