From: Junio C Hamano Date: Mon, 12 Aug 2024 15:50:32 GMT Subject: Re: [PATCH v2 00/22] Memory leak fixes (pt.4) Message-ID: In-Reply-To: <4dbf731a-873b-4cab-b8ff-745bfa059060@gmail.com> Phillip Wood writes: > On 08/08/2024 14:04, Patrick Steinhardt wrote: >> Hi, >> this is the second version of my fourth batch of patches that fix >> various memory leaks. >> Changes compared to v1: >> - Adapt the memory leak fix for command characters to instead use >> a >> `comment_line_str_allocated` variable. >> - Clarify some commit messages. >> - Drop the TODO comment about `rebase.gpgsign`. Turns out that >> this is >> working as intended, as explained by Phillip. > > The changes to the rebase and sequencer patches look good to me > > Thanks > > Phillip Thanks for a review.