Re: [PATCH/RFC 0/3] pedantic errors in next

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 11, 2021, 17:20 UTC
Message-ID: <xmqq5ywbaoey.fsf@gitster.g>
In-Reply-To: <1a18a701-7d14-d6c5-6929-30636e688006@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 6 quoted lines

>> would at least the two included in the chunks above be safe enough for
>> RC2 as I hope?, is the one with the additional int too hacky to be
>> considered for release?;
>
> I think your -pedantic fixes 1 and 2 should go into the next possible
> release candidate because they fix regressions.

I agree. They are at the bottom of 'seen' just above 'master' in last night's pushout for this exact reason.

Show 5 quoted lines

> Same for my signed-left-shift fix in
> http://public-inbox.org/git/bab9f889-ee2e-d3c3-0319-e297b59261a0@web.de/
> (or some improved version if it's lacking in some way) and the yet to be
> published fix for the alignment issue.  I assume Andrzej as the reporter
> or Eric as the original author would like to have a shot at the latter.

Thanks. It was missed as it was buried in the discussion exchange. Will queue together with cb/many-alternate-optim-fixup topic.