Re: [PATCH v3 2/3] win32: allow building with pedantic mode enabled

From: Jonathan Tan <jonathantanmy@google.com>
Date: Sep 28, 2021, 20:16 UTC
Message-ID: <20210928201613.1110573-1-jonathantanmy@google.com>
In-Reply-To: <xmqq35polhye.fsf@gitster.g>

Show 18 quoted lines

> Carlo Arenas <carenas@gmail.com> writes:
> 
> > On Mon, Sep 27, 2021 at 4:04 PM Jonathan Tan <jonathantanmy@google.com> wrote:
> >>
> >> > +ifneq ($(filter gcc5,$(COMPILER_FEATURES)),)
> >> > +DEVELOPER_CFLAGS += -Wno-incompatible-pointer-types
> >> > +endif
> >>
> >> I noticed today that I wasn't warned about some incompatible function
> >> pointer signatures (that I expected to be warned about) due to this
> >> line - could the condition of adding this compiler flag be further
> >> narrowed down? gcc -v says:
> >
> > Apologies; it is gone already in "seen" (and hopefully soon in "next")
> > by merging js/win-lazyload-buildfix[1]
> 
> I will mark it not ready for 'next', while waiting for a fix-up.
> Thanks for stopping me.

Just checking - which branch is not ready for next? The issue I noticed is already in master, and js/win-lazyload-buildfix contains the fix for the issue (which ideally would be merged as soon as possible, but merging according to the usual schedule is fine).