Re: [PATCH v3 2/3] win32: allow building with pedantic mode enabled

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 28, 2021, 17:37 UTC
Message-ID: <xmqq35polhye.fsf@gitster.g>
In-Reply-To: <CAPUEsphk9b0TpUDgW9qkG=ehKx+hPi5GNtqTP2o2MeL1VpHHPQ@mail.gmail.com>

Carlo Arenas <carenas@gmail.com> writes:

Show 13 quoted lines

> On Mon, Sep 27, 2021 at 4:04 PM Jonathan Tan <jonathantanmy@google.com> wrote:
>>
>> > +ifneq ($(filter gcc5,$(COMPILER_FEATURES)),)
>> > +DEVELOPER_CFLAGS += -Wno-incompatible-pointer-types
>> > +endif
>>
>> I noticed today that I wasn't warned about some incompatible function
>> pointer signatures (that I expected to be warned about) due to this
>> line - could the condition of adding this compiler flag be further
>> narrowed down? gcc -v says:
>
> Apologies; it is gone already in "seen" (and hopefully soon in "next")
> by merging js/win-lazyload-buildfix[1]

I will mark it not ready for 'next', while waiting for a fix-up. Thanks for stopping me.