Re: [PATCH v3 2/3] win32: allow building with pedantic mode enabled
- From
Carlo Arenas <carenas@gmail.com>
- Date
- Sep 28, 2021, 00:30 UTC
- Message-ID
- <CAPUEsphk9b0TpUDgW9qkG=ehKx+hPi5GNtqTP2o2MeL1VpHHPQ@mail.gmail.com>
- In-Reply-To
- <20210927230438.3759964-1-jonathantanmy@google.com>
On Mon, Sep 27, 2021 at 4:04 PM Jonathan Tan <jonathantanmy@google.com> wrote:
Show 9 quoted lines
> > > +ifneq ($(filter gcc5,$(COMPILER_FEATURES)),) > > +DEVELOPER_CFLAGS += -Wno-incompatible-pointer-types > > +endif > > I noticed today that I wasn't warned about some incompatible function > pointer signatures (that I expected to be warned about) due to this > line - could the condition of adding this compiler flag be further > narrowed down? gcc -v says:
Apologies; it is gone already in "seen" (and hopefully soon in "next") by merging js/win-lazyload-buildfix[1]
> gcc version 10.3.0 (Debian 10.3.0-9+build2) > > On my system, if I remove that line, "make DEVELOPER=1" is still > successful.
Correct; it was only needed in Windows, will narrow it further.
Carlo
[1] https://github.com/gitster/git/tree/js/win-lazyload-buildfix