Re: [PATCH v3 2/3] win32: allow building with pedantic mode enabled

From: Carlo Arenas <carenas@gmail.com>
Date: Sep 29, 2021, 01:00 UTC
Message-ID: <CAPUEsphVJBCPLSfOyH2bqTCpcDvtPuOVGQsD3XaWVuZbFiVUeA@mail.gmail.com>
In-Reply-To: <20210928201613.1110573-1-jonathantanmy@google.com>

On Tue, Sep 28, 2021 at 1:16 PM Jonathan Tan <jonathantanmy@google.com> wrote:

Show 13 quoted lines

>
> > Carlo Arenas <carenas@gmail.com> writes:
> >
> > > Apologies; it is gone already in "seen" (and hopefully soon in "next")
> > > by merging js/win-lazyload-buildfix[1]
> >
> > I will mark it not ready for 'next', while waiting for a fix-up.
> > Thanks for stopping me.
>
> Just checking - which branch is not ready for next? The issue I noticed
> is already in master, and js/win-lazyload-buildfix contains the fix for
> the issue (which ideally would be merged as soon as possible, but
> merging according to the usual schedule is fine).

My guess was that he meant to have also the windows specific check added as part of this branch, and that would have prevented the issue you reported originally as well.

Either way, a v4 has been posted[1] (sorry, forgot to CC you), and hopefully that is now ready for next ;)

Carlo

[1] https://lore.kernel.org/git/20210929004832.96304-1-carenas@gmail.com/