Re: [PATCH v3 2/3] win32: allow building with pedantic mode enabled

From: Carlo Arenas <carenas@gmail.com>
Date: Sep 4, 2021, 14:42 UTC
Message-ID: <CAPUEspheuPPfbCv59ouNcq4Ac8-6LvOAwDO3V3F9UJGHm+Qwyg@mail.gmail.com>
In-Reply-To: <5983c238-e926-3b08-ed10-1de1343a8d00@web.de>

On Sat, Sep 4, 2021 at 2:37 AM René Scharfe <l.s.r@web.de> wrote:

Show 25 quoted lines

>
> Am 03.09.21 um 22:38 schrieb René Scharfe:
> > Am 03.09.21 um 22:13 schrieb Carlo Marcelo Arenas Belón:
> >> On Fri, Sep 03, 2021 at 08:47:02PM +0200, René Scharfe wrote:
> >>> Am 03.09.21 um 19:02 schrieb Carlo Marcelo Arenas Belón:
> >>>> diff --git a/compat/nedmalloc/nedmalloc.c b/compat/nedmalloc/nedmalloc.c
> >>>> index 1cc31c3502..edb438a777 100644
> >>>> --- a/compat/nedmalloc/nedmalloc.c
> >>>> +++ b/compat/nedmalloc/nedmalloc.c
> >>>> @@ -510,7 +510,7 @@ static void threadcache_free(nedpool *p, threadcache *tc, int mymspace, void *me
> >>>>    assert(idx<=THREADCACHEMAXBINS);
> >>>>    if(tck==*binsptr)
> >>>>    {
> >>>> -          fprintf(stderr, "Attempt to free already freed memory block %p - aborting!\n", tck);
> >>>> +          fprintf(stderr, "Attempt to free already freed memory block %p - aborting!\n", (void *)tck);
> >>>
> >>> This change is not mentioned in the commit message.
> >>
> >> got me there, I was intentionally trying to ignore it since nedmalloc gives
> >> me PTSD and is obsoleted AFAIK[1], so just adding a casting to void (while
> >> ugly) was also less intrusive.
>
> Expected your [1] to stand for a footnote, and got confused when I found none.
> The last commit in https://github.com/ned14/nedmalloc is from seven years ago
> and this repository is archived, with the author still being active on GitHub.

> Seems like nedmalloc reached its end of life.  Has there been an official
> announcement?

Apologies; this is the [1] I was referring to:

[1] https://lore.kernel.org/git/nycvar.QRO.7.76.6.1908082213400.46@tvgsbejva qbjf.bet/

TLDR; nedmalloc works but is only stable in Windows, and indeed shows other warnings in macOS that would have broken a DEVELOPER=1 build as well which I am ignoring.

 compat/nedmalloc/nedmalloc.c:326:8: warning: address of array
'p->caches' will always evaluate to 'true' [-Wpointer-bool-conversion]
        if(p->caches)
        ~~ ~~~^~~~~~
1 warning generated.

Carlo