Re: [PATCH 05/23] pack v4: add commit object parsing

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 27, 2013, 17:42 UTC
Message-ID: <xmqq4nabdo82.fsf@gitster.dls.corp.google.com>
In-Reply-To: <alpine.LFD.2.03.1308271238270.14472@syhkavp.arg>

Nicolas Pitre <nico@fluxnic.net> writes:

> Hmmm....  The problem I have with split_ident_line() right now is about 
> the fact that it is too liberal with whitespaces.  Here I must be sure I 
> can deconstruct a commit object and be sure I still can regenerate it 
> byte for byte in order to match its SHA1 signature.

Yeah, I now see. It's the same "accept with leniency" get_sha1_hex() does, which is not appropriate for the purpose of this codepath.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.