Re: [PATCH 00/23] Preliminary pack v4 support
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Aug 28, 2013, 02:30 UTC
- Message-ID
- <CACsJy8AttNxePUG9cKw9ihAmRd=kFpcsgwe2yj_FRQbhc-akCg@mail.gmail.com>
- In-Reply-To
- <xmqq8uzndqws.fsf@gitster.dls.corp.google.com>
On Tue, Aug 27, 2013 at 11:44 PM, Junio C Hamano <gitster@pobox.com> wrote:
> As you have "0-index" escape hatch for SHA-1 table, but no similar > escape hatch for the people's name table, I can see why it may be > cumbersome to fix a thin pack by only appending to a received > packfile and updating a few header fields, though.
We also need an escape hatch for path name table. But what if we store appended objects in OBJ_REF_DELTA format where base ref is empty tree/commit and cached by sha1_file.c? We won't need to update dictionary tables. Parsing is a bit ugly though (e.g. v3 tree with v2 base) but we have to deal with that anyway because people can have v2 and v3 packs mixed in.
-- Duy