Re: [PATCH v3] Document pack v4 format
- From
Nicolas Pitre <nico@fluxnic.net>
- Date
- Sep 6, 2013, 13:25 UTC
- Message-ID
- <alpine.LFD.2.03.1309060922020.20709@syhkavp.arg>
- In-Reply-To
- <CACsJy8AWa0NFViO+3Cnp_0Gqzqidcbx9vPd1wxCuY1jjWhyFaQ@mail.gmail.com>
On Fri, 6 Sep 2013, Duy Nguyen wrote:
Show 18 quoted lines
> On Fri, Sep 6, 2013 at 10:23 AM, Nicolas Pitre <nico@fluxnic.net> wrote: > > On Fri, 6 Sep 2013, Nguyn Thái Ng÷c Duy wrote: > > > >> > >> Signed-off-by: Nguyn Thái Ng÷c Duy <pclouds@gmail.com> > >> --- > >> Should be up to date with Nico's latest implementation and also cover > >> additions to the format that everybody seems to agree on: > >> > >> - new types for canonical trees and commits > >> - sha-1 table covering missing objects in thin packs > > > > Great! I've merged this into my branch with the following amendment: > > I'd like to propose another change in the format to basically limit > the use of sha1ref format "\0<SHA-1>" to tree entries only. All forms > of deltas must have non-zero sha1 index (i.e. reference to SHA-1 > table). It will simplify handling code, and I think it makes sense too
Why?
This is still some artificial limitation and I tend not to like them.
"Simplifying handling code" is not a good enough reason on its own, especially if it reduce flexibility for possible future layout optimizations.
In what way is the code more difficult?
Nicolas