Re: [PATCH 14/23] pack v4: object data copy

From: Nicolas Pitre <nico@fluxnic.net>
Date: Aug 27, 2013, 18:24 UTC
Message-ID: <alpine.LFD.2.03.1308271409320.14472@syhkavp.arg>
In-Reply-To: <xmqqli3ndt9z.fsf@gitster.dls.corp.google.com>

On Tue, 27 Aug 2013, Junio C Hamano wrote:

Show 20 quoted lines

> Nicolas Pitre <nico@fluxnic.net> writes:
> 
> > Blob and tag objects have no particular changes except for their object
> > header.
> >
> > Delta objects are also copied as is, except for their delta base reference
> > which is converted to the new way as used elsewhere in pack v4 encoding
> > i.e. an index into the SHA1 table or a literal SHA1 prefixed by 0 if not
> > found in the table (see add_sha1_ref).  This is true for both REF_DELTA
> > as well as OFS_DELTA.
> >
> > Object payload is validated against the recorded CRC32 in the source
> > pack index file when possible.
> >
> > Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
> > ---
> 
> The title somewhat confused me until I realized that this series is
> building a program that would convert existing data from a single
> pack into packv4 format, not a "pack-objects --pack-verison=4".

I initially started with extensions to pack-objects but that quickly became a big hassle to keep things working while experimenting. So this tool is just a straight pack converter which in itself turned out to be quite complex already. Eventually its code could be merged into pack-objects.

Nicolas