Re: [PATCH v2] Document pack v4 format
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Sep 5, 2013, 05:04 UTC
- Message-ID
- <CACsJy8CX=4Oz_h2NtS3FRdK6_zdFksa+JR5C6Z-z3Y70PLAsyQ@mail.gmail.com>
- In-Reply-To
- <alpine.LFD.2.03.1309050024090.14472@syhkavp.arg>
On Thu, Sep 5, 2013 at 11:40 AM, Nicolas Pitre <nico@fluxnic.net> wrote:
Show 12 quoted lines
> On Thu, 5 Sep 2013, Duy Nguyen wrote: > >> On Thu, Sep 5, 2013 at 11:12 AM, Nicolas Pitre <nico@fluxnic.net> wrote: >> > Many other bugs have now been fixed. A git.git repository with packs >> > version 4 appears to be functional and passes git-fsck --full --strict. >> >> Yeah I was looking at the diff some minutes ago, saw changes in >> pack-check.c and wondering if fsck was working. I'll add v4 support to >> index-pack. > > Beware that the tree delta encoding has changed a little. This saved up > to 2% on some repos.
Thanks for the heads up.
Show 19 quoted lines
> I'll probably change the encoding to incorporate the escape hatch > for path and name references as discussed previously. > >> Waiting to see the new, v4-aware tree walker interface >> with good "rev-list --all --objects" numbers from you. > > Well, unfortunately I've put more time than I really had available into > this project lately. I'm about to call for other people to take over it > and pursue this work further. > > I really wanted to set the pack format direction since I've been toying > with this for so many years. Now the tool to convert a pack is there, > and the read side is also there, proving that the format does work and > the encoding and decoding code is functional and may serve as reference. > So that's about the extent of what I can contribute at this point. > > I'll be happy to provide design assistance and code review comments of > course. But I won't be able to put the time to do the actual coding > myself much longer.
You've done a great job in designing v4 and getting basic support in place. I think you'll need to post your series again so Junio can pick it up. Then we (at least I) will try to continue from there. I have high hopes that this will not drop out like the spit-blob series.
-- Duy