Re: [PATCH v3] Document pack v4 format

From: Nicolas Pitre <nico@fluxnic.net>
Date: Sep 7, 2013, 04:57 UTC
Message-ID: <alpine.LFD.2.03.1309070054320.20709@syhkavp.arg>
In-Reply-To: <alpine.LFD.2.03.1309061224350.20709@syhkavp.arg>

On Fri, 6 Sep 2013, Nicolas Pitre wrote:

Show 9 quoted lines

> On Fri, 6 Sep 2013, Duy Nguyen wrote:
> 
> > In your code you reject sha1ref starting with zero too
> > (sha1_file.c::get_base_delta and packv4-parse.c::decode_entries)
> 
> Yeah... because I wrote the minimum code to make it work with the 
> current encoder.  But the decoder could be more lenient than that.  It's 
> just a matter of adding a call to find_pack_entry_one() when the sha1ref 
> index is 0.

FYI I've added the missing code to packv4-parse.c::decode_entries. The code in sha1_file.c::get_delta_base was already fine.

Nicolas

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.