Re: [PATCH 09/23] pack v4: commit object encoding

From: Nicolas Pitre <nico@fluxnic.net>
Date: Aug 27, 2013, 19:59 UTC
Message-ID: <alpine.LFD.2.03.1308271553530.14472@syhkavp.arg>
In-Reply-To: <xmqqy57ndtxb.fsf@gitster.dls.corp.google.com>

On Tue, 27 Aug 2013, Junio C Hamano wrote:

Show 11 quoted lines

> Nicolas Pitre <nico@fluxnic.net> writes:
> 
> > +	/* parse the "tree" line */
> > +	if (in + 46 >= tail || memcmp(in, "tree ", 5) || in[45] != '\n')
> > +		goto bad_data;
> > +	if (get_sha1_hex(in + 5, sha1) < 0)
> > +		goto bad_data;
> 
> Is this strict enough to guarantee roundtrip hash identity?  Because
> get_sha1_hex() accepts hexadecimal represented with uppercase A-F,
> you need to reject such a "broken" commit object, no?

BTW, is there any such objects in existence where sha1 ascii strings are represented using uppercase letters? Because there would be a simple way to encode that fact in the pack v4 sha1 reference... but that change has to happen now.

I'm already claiming we won't support mixed case though.

Nicolas