git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] doc: replace jargon word "impact" with "effect"/"affect"

From
Junio C Hamano <gitster@pobox.com>
Date
May 11, 2021, 13:22 UTC
Message-ID
<xmqq35utmmll.fsf@gitster.g>
In-Reply-To
<20210511104326.GJ12700@kitsune.suse.cz>
Michal Suchánek <msuchanek@suse.de> writes:
Show 18 quoted lines
> Since you can look up the meaning of the word in a general purpose
> dictionary it should be an acceptable use even if it's less commonly
> used in some other English-speaking parts of the world.
> ...
> They are not confusing in the way they are used. That is 'does not
> impact' in the maning 'has no or negligible effect', and especially in
> the cases where the degree of effect is not considered and only there
> being an effect or not is discussed there is no room for confusion.
> ...
> ...
> This topic somewhat interests me so I was continuing this discussion
> in the hope that you either provide a specific very confusing use of the
> word impact in the documentation that triggered creating this patch or
> some solid evidence that the general use of word 'impact' as synonym for
> affect/effect is in some way problematic but niether happened.
>
> I think this topic has been discussed sufficiently and there is nothing
> more to add.
Thanks.

As you said, lack of a specific example of what is universally confusing, or at least confusing to a not-so-insignificant part of the readership, was why this change didn't gain much support. There might be one or two such places where the updated text does read better, but it is not a very good use of reviewers' time to find such needles in 700+ line haystack of a patch.

Previous: Michal SuchánekNext: Felipe Contreras
Message 16 of 68 in “doc: replace jargon word "impact" with "effect"/"affect"”
  1. doc: replace jargon word "impact" with "effect"/"affect"Varun Varada, Apr 5, 2021
  2. Michal SuchánekApr 6, 2021
  3. Varun VaradaApr 6, 2021
  4. Jeff KingApr 6, 2021
  5. Varun VaradaApr 7, 2021
  6. Varun VaradaApr 28, 2021
  7. Michal SuchánekApr 28, 2021
  8. Varun VaradaApr 28, 2021
  9. Michal SuchánekApr 28, 2021
  10. Varun VaradaApr 30, 2021
  11. Michal SuchánekApr 30, 2021
  12. Varun VaradaMay 10, 2021
  13. Michal SuchánekMay 10, 2021
  14. Varun VaradaMay 10, 2021
  15. Michal SuchánekMay 11, 2021
  16. Junio C HamanoMay 11, 2021
  17. Felipe ContrerasMay 12, 2021
  18. Felipe ContrerasMay 12, 2021
  19. Felipe ContrerasMay 12, 2021
  20. Felipe ContrerasMay 12, 2021
  21. Felipe ContrerasMay 12, 2021
  22. Felipe ContrerasMay 12, 2021
  23. Felipe ContrerasMay 11, 2021
  24. Michal SuchánekMay 11, 2021
  25. Varun VaradaMay 11, 2021
  26. Felipe ContrerasMay 12, 2021
  27. Michal SuchánekMay 12, 2021
  28. Felipe ContrerasMay 12, 2021
  29. Michal SuchánekMay 12, 2021
  30. Felipe ContrerasMay 12, 2021
  31. Michal SuchánekMay 12, 2021
  32. Michal SuchánekMay 12, 2021
  33. Felipe ContrerasMay 12, 2021
  34. Michal SuchánekMay 12, 2021
  35. Robert P. J. DayMay 12, 2021
  36. Kerry, RichardMay 12, 2021
  37. Varun VaradaMay 12, 2021
  38. Michal SuchánekMay 12, 2021
  39. Felipe ContrerasMay 12, 2021
  40. Michal SuchánekMay 12, 2021
  41. Felipe ContrerasMay 12, 2021
  42. Michal SuchánekMay 13, 2021
  43. Felipe ContrerasMay 13, 2021
  44. Robert CoupMay 13, 2021
  45. Michal SuchánekMay 13, 2021
  46. Felipe ContrerasMay 13, 2021
  47. Varun VaradaMay 26, 2021
  48. Michal SuchánekMay 27, 2021
  49. Felipe ContrerasMay 27, 2021
  50. Michal SuchánekMay 27, 2021
  51. Felipe ContrerasMay 27, 2021
  52. Varun VaradaJun 12, 2021
  53. Michal SuchánekJun 13, 2021
  54. Felipe ContrerasJun 13, 2021
  55. Michal SuchánekJun 13, 2021
  56. Felipe ContrerasJun 13, 2021
  57. Varun VaradaMay 12, 2021
  58. Felipe ContrerasMay 13, 2021
  59. Felipe ContrerasMay 12, 2021
  60. Felipe ContrerasMay 11, 2021
  61. Michal SuchánekMay 11, 2021
  62. Felipe ContrerasMay 12, 2021
  63. Michal SuchánekMay 12, 2021
  64. Felipe ContrerasMay 12, 2021
  65. Varun VaradaMay 12, 2021
  66. Philip OakleyMay 13, 2021
  67. Varun VaradaMay 26, 2021
  68. Philip OakleyMay 27, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.