Re: [PATCH] doc: replace jargon word "impact" with "effect"/"affect"

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 12, 2021, 03:02 UTC
Message-ID: <609b454d33df2_678ff208f9@natae.notmuch>
In-Reply-To: <xmqq35utmmll.fsf@gitster.g>

Junio C Hamano wrote:

> As you said, lack of a specific example of what is universally
> confusing, or at least confusing to a not-so-insignificant part of
> the readership, was why this change didn't gain much support.

The original version doesn't necessarily need to be confusing.

It's sufficient that the new version is better.

> There might be one or two such places where the updated text does read
> better, but it is not a very good use of reviewers' time to find such
> needles in 700+ line haystack of a patch.

As a reviewer I will decide where I to allocate my reviewer's time, because it's my time.

-- 
Felipe Contreras

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.