git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] doc: replace jargon word "impact" with "effect"/"affect"

From
Michal Suchánek <msuchanek@suse.de>
Date
May 12, 2021, 04:09 UTC
Message-ID
<20210512040926.GN12700@kitsune.suse.cz>
In-Reply-To
<609b4eea1088a_678ff208ba@natae.notmuch>
On Tue, May 11, 2021 at 10:43:38PM -0500, Felipe Contreras wrote:
Show 47 quoted lines
> Varun Varada wrote:
> 
> > Re: your point about me not pointing out specific examples: the
> > command output for detached HEAD state reads "you can discard any
> > commits you make in this state without impacting any branches by
> > switching back to a branch". I'm incredibly passionate about this
> > example. Here, the user is left to think, "wait...so this will not
> > impact (significantly affect) any branches, but will it affect them?
> > As in, are there side effects that I should be aware of? Where do I go
> > to find out what they are?" All of this mental energy is completely
> > unnecessary. Mind you, this is regarding discarding commits, which is
> > a destructive action.
> 
> Completely agree.
> 
> I'm not a native speaker of English, but nowadays I use English more
> than any other language, and when I read *impact* I read alarm bells.
> 
> First I'm reminded of "brace for impact", which something nobody should
> take lightly (native speaker or not), and when I search for "impact" on
> IMDB the first result I find is Deep Impact [1]. Not something bland.
> Maybe my understanding of the word has been tainted by my experience,
> sure...
> 
> But I'm still waiting for anybody to explain what's wrong with "affect".
> 
> > > > But why bother? The word "affect" is a much superior choice.
> > >
> > > Why bother with a chenge at all?
> > 
> > It seems like you already previously agreed with the premise that the
> > word means "a significant effect" or "to significantly affect". I
> > understand and appreciate your thoroughness to scrutinize changes to
> > the repo, but I'm frankly surprised that such a small change is
> > attracting such fierce debate. This is meant to be a change that is
> > probably one of the easiest ones to decide on: it only consists of
> > one-word changes that don't change functionality, yet undeniably
> > reduce confusion.
> 
> When I started contributing to the git project more than 10 years ago I
> noticed precisely the same thing.
> 
> It is a paradox called "the bikeshedding effect". When you contribute a
> complex and convoluted change it's easier to get it in because few people
> can object (as few people can understand it). But when you contribute a
> change as simple as changing the color of something, then *everyone* can
> opine (literally).

You forget that what you are doing right now is bikeshedding after the fact.

You can use 'affect' or 'impact' and it generally conveys the same meaning. Some speakers find 'affect' more natural. Clearly other speakers such as authors of the changes that use the word 'impact' find 'impact' more natural. If we give in to the desire to pick the more natural sounding synonym we will get endless back and forth of patches changing one synonym to another.

Thanks
Michal
Previous: Felipe ContrerasNext: Felipe Contreras
Message 27 of 68 in “doc: replace jargon word "impact" with "effect"/"affect"”
  1. doc: replace jargon word "impact" with "effect"/"affect"Varun Varada, Apr 5, 2021
  2. Michal SuchánekApr 6, 2021
  3. Varun VaradaApr 6, 2021
  4. Jeff KingApr 6, 2021
  5. Varun VaradaApr 7, 2021
  6. Varun VaradaApr 28, 2021
  7. Michal SuchánekApr 28, 2021
  8. Varun VaradaApr 28, 2021
  9. Michal SuchánekApr 28, 2021
  10. Varun VaradaApr 30, 2021
  11. Michal SuchánekApr 30, 2021
  12. Varun VaradaMay 10, 2021
  13. Michal SuchánekMay 10, 2021
  14. Varun VaradaMay 10, 2021
  15. Michal SuchánekMay 11, 2021
  16. Junio C HamanoMay 11, 2021
  17. Felipe ContrerasMay 12, 2021
  18. Felipe ContrerasMay 12, 2021
  19. Felipe ContrerasMay 12, 2021
  20. Felipe ContrerasMay 12, 2021
  21. Felipe ContrerasMay 12, 2021
  22. Felipe ContrerasMay 12, 2021
  23. Felipe ContrerasMay 11, 2021
  24. Michal SuchánekMay 11, 2021
  25. Varun VaradaMay 11, 2021
  26. Felipe ContrerasMay 12, 2021
  27. Michal SuchánekMay 12, 2021
  28. Felipe ContrerasMay 12, 2021
  29. Michal SuchánekMay 12, 2021
  30. Felipe ContrerasMay 12, 2021
  31. Michal SuchánekMay 12, 2021
  32. Michal SuchánekMay 12, 2021
  33. Felipe ContrerasMay 12, 2021
  34. Michal SuchánekMay 12, 2021
  35. Robert P. J. DayMay 12, 2021
  36. Kerry, RichardMay 12, 2021
  37. Varun VaradaMay 12, 2021
  38. Michal SuchánekMay 12, 2021
  39. Felipe ContrerasMay 12, 2021
  40. Michal SuchánekMay 12, 2021
  41. Felipe ContrerasMay 12, 2021
  42. Michal SuchánekMay 13, 2021
  43. Felipe ContrerasMay 13, 2021
  44. Robert CoupMay 13, 2021
  45. Michal SuchánekMay 13, 2021
  46. Felipe ContrerasMay 13, 2021
  47. Varun VaradaMay 26, 2021
  48. Michal SuchánekMay 27, 2021
  49. Felipe ContrerasMay 27, 2021
  50. Michal SuchánekMay 27, 2021
  51. Felipe ContrerasMay 27, 2021
  52. Varun VaradaJun 12, 2021
  53. Michal SuchánekJun 13, 2021
  54. Felipe ContrerasJun 13, 2021
  55. Michal SuchánekJun 13, 2021
  56. Felipe ContrerasJun 13, 2021
  57. Varun VaradaMay 12, 2021
  58. Felipe ContrerasMay 13, 2021
  59. Felipe ContrerasMay 12, 2021
  60. Felipe ContrerasMay 11, 2021
  61. Michal SuchánekMay 11, 2021
  62. Felipe ContrerasMay 12, 2021
  63. Michal SuchánekMay 12, 2021
  64. Felipe ContrerasMay 12, 2021
  65. Varun VaradaMay 12, 2021
  66. Philip OakleyMay 13, 2021
  67. Varun VaradaMay 26, 2021
  68. Philip OakleyMay 27, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.