git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] doc: replace jargon word "impact" with "effect"/"affect"

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 12, 2021, 03:21 UTC
Message-ID
<609b49c85d761_678ff208cd@natae.notmuch>
In-Reply-To
<20210511202502.GM12700@kitsune.suse.cz>
Michal Suchánek wrote:
Show 20 quoted lines
> On Tue, May 11, 2021 at 02:59:32PM -0500, Felipe Contreras wrote:
> > Varun Varada wrote:
> > > On Tue, 6 Apr 2021 at 04:24, Michal Suchánek <msuchanek@suse.de> wrote:
> > > > while using "will not impact" in an incorrect or unclear way may be a
> > > > problem the word "impact" in itself is not "jargon".
> > > 
> > > The word means "to have a strong or marked effect on" (v.) and "a
> > > strong or market influence" (n.) when used figuratively; it is not
> > > synonymous with "affect" and "effect", respectively, as shown even by
> > > all of the entries you've cited. Using it as such is the incorrect
> > > part, so those are the instances I've changed in the diff.
> > 
> > There are two ways impact can be used as a verb: transitive and
> > intransitive, but git doesn't seem to be using the intransitive form. In
> > the transitive form it usually means to strike "the car impacted the
> > tree". But it can also mean to have a desired effect "reducing CO2
> > emissions impacted climate change".
> 
> I don't know where you find the 'desired' effect meaning. Certainly none
> of the dictionaries I consulted at random provides such definition.
You yourself consulted Merriam-Webster [1]:
  impact _verb_
  : to have a direct effect or impact on : impinge on
Did you not? [2]
Show 9 quoted lines
> > None of these are used in the documentation, we have things like:
> > 
> >   the index does not impact the outcome
> > 
> > Which is clearly wrong (unless we are talking about possitive outcome of
> > the outcome, which makes no sense).
> 
> It is not clearly wrong. To me it makes perfect sense. If you want to
> claim it's wrong please provide a source for your claim.
Merriam-Webster [1].
Show 10 quoted lines
> > As a noun it can mean a siginificant or major effect: "the impact of
> > science".
> > 
> > However, the documentation is not using it that way:
> > 
> >   the runtime impact of tracking all omitted objects
> > 
> > The noun usage is less wrong than the verb usage, but it's still wrong.
> 
> Why is that wrong?
Because it's not a "a significant or major effect" [1].
> How did you infer that the effect is insignificant or minor?
I did not.

If I claim temperature $x is not hot, that doesn't mean I'm claiming it's cold.

> In fact while some dictionaries list 'impact' as 'have strong effect'
> the Oxford dicrionary lists is as simply synonymous to 'affect'.

Synonymous doesn't mean equal. In fact, the Oxford dictionary defines "impact" as [3]:

 the powerful effect that something has on somebody/something
Note: *powerful*.
> > But why bother? The word "affect" is a much superior choice.
> 
> Why bother with a chenge at all?
Because it's better.
Do you have any evidence that it's worse?

[1] https://www.merriam-webster.com/dictionary/impact [2] https://lore.kernel.org/git/20210406092440.GZ6564@kitsune.suse.cz/ [3] https://www.oxfordlearnersdictionaries.com/definition/english/impact_1

-- 
Felipe Contreras
Previous: Felipe ContrerasNext: Felipe Contreras
Message 59 of 68 in “doc: replace jargon word "impact" with "effect"/"affect"”
  1. doc: replace jargon word "impact" with "effect"/"affect"Varun Varada, Apr 5, 2021
  2. Michal SuchánekApr 6, 2021
  3. Varun VaradaApr 6, 2021
  4. Jeff KingApr 6, 2021
  5. Varun VaradaApr 7, 2021
  6. Varun VaradaApr 28, 2021
  7. Michal SuchánekApr 28, 2021
  8. Varun VaradaApr 28, 2021
  9. Michal SuchánekApr 28, 2021
  10. Varun VaradaApr 30, 2021
  11. Michal SuchánekApr 30, 2021
  12. Varun VaradaMay 10, 2021
  13. Michal SuchánekMay 10, 2021
  14. Varun VaradaMay 10, 2021
  15. Michal SuchánekMay 11, 2021
  16. Junio C HamanoMay 11, 2021
  17. Felipe ContrerasMay 12, 2021
  18. Felipe ContrerasMay 12, 2021
  19. Felipe ContrerasMay 12, 2021
  20. Felipe ContrerasMay 12, 2021
  21. Felipe ContrerasMay 12, 2021
  22. Felipe ContrerasMay 12, 2021
  23. Felipe ContrerasMay 11, 2021
  24. Michal SuchánekMay 11, 2021
  25. Varun VaradaMay 11, 2021
  26. Felipe ContrerasMay 12, 2021
  27. Michal SuchánekMay 12, 2021
  28. Felipe ContrerasMay 12, 2021
  29. Michal SuchánekMay 12, 2021
  30. Felipe ContrerasMay 12, 2021
  31. Michal SuchánekMay 12, 2021
  32. Michal SuchánekMay 12, 2021
  33. Felipe ContrerasMay 12, 2021
  34. Michal SuchánekMay 12, 2021
  35. Robert P. J. DayMay 12, 2021
  36. Kerry, RichardMay 12, 2021
  37. Varun VaradaMay 12, 2021
  38. Michal SuchánekMay 12, 2021
  39. Felipe ContrerasMay 12, 2021
  40. Michal SuchánekMay 12, 2021
  41. Felipe ContrerasMay 12, 2021
  42. Michal SuchánekMay 13, 2021
  43. Felipe ContrerasMay 13, 2021
  44. Robert CoupMay 13, 2021
  45. Michal SuchánekMay 13, 2021
  46. Felipe ContrerasMay 13, 2021
  47. Varun VaradaMay 26, 2021
  48. Michal SuchánekMay 27, 2021
  49. Felipe ContrerasMay 27, 2021
  50. Michal SuchánekMay 27, 2021
  51. Felipe ContrerasMay 27, 2021
  52. Varun VaradaJun 12, 2021
  53. Michal SuchánekJun 13, 2021
  54. Felipe ContrerasJun 13, 2021
  55. Michal SuchánekJun 13, 2021
  56. Felipe ContrerasJun 13, 2021
  57. Varun VaradaMay 12, 2021
  58. Felipe ContrerasMay 13, 2021
  59. Felipe ContrerasMay 12, 2021
  60. Felipe ContrerasMay 11, 2021
  61. Michal SuchánekMay 11, 2021
  62. Felipe ContrerasMay 12, 2021
  63. Michal SuchánekMay 12, 2021
  64. Felipe ContrerasMay 12, 2021
  65. Varun VaradaMay 12, 2021
  66. Philip OakleyMay 13, 2021
  67. Varun VaradaMay 26, 2021
  68. Philip OakleyMay 27, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.