Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

From: Junio C Hamano <gitster@pobox.com>
Date: May 26, 2015, 22:21 UTC
Message-ID: <xmqq1ti3j7ym.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1432677675-5118-9-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 7 quoted lines

> +	if (transport->smart_options
> +	    && transport->smart_options->transport_version) {
> +		buf = xmalloc(strlen(remote_program) + 12);
> +		sprintf(buf, "%s-%d", remote_program,
> +			transport->smart_options->transport_version);
> +		remote_program = buf;
> +	}

Bikeshedding: so the versioning scheme is that the current one is
zero, and the next one is two?  I would have expected that there
would be something like

	if (...->version < 2) {
        	... append "-%d" ...
	}

involved.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.