Re: [RFC/WIP PATCH 07/11] fetch-pack: use the configured transport protocol

From: Stefan Beller <sbeller@google.com>
Date: May 26, 2015, 22:23 UTC
Message-ID: <CAGZ79kbuU1YwhxCnT7YRN=-cBsY0R820Mm2QTHJuMBju6r8Zew@mail.gmail.com>
In-Reply-To: <xmqq617fj81l.fsf@gitster.dls.corp.google.com>

On Tue, May 26, 2015 at 3:19 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> @@ -175,7 +179,18 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix)
>>               if (!conn)
>>                       return args.diag_url ? 0 : 1;
>>       }
>> -     get_remote_heads(fd[0], NULL, 0, &ref, 0, NULL, &shallow);
>> +
>> +     switch (args.version) {
>> +     default:
>> +     case 2:
>> +             get_remote_capabilities(fd[0], NULL, 0);
>> +             request_capabilities(fd[1]);
>> +             break;

Actually this is wrong, we need to actually fall through from here as well, so we not only talk capabilities negotiation, but then continue with get_remote_heads.

Show 7 quoted lines

>> +     case 1: /* fall through */
>> +     case 0:
>> +             get_remote_heads(fd[0], NULL, 0, &ref, 0, NULL, &shallow);
>> +             break;
>> +     }
>
> Nice ;-)