Re: [RFC/WIP PATCH 02/11] upload-pack: only accept capabilities on the first "want" line

From: Stefan Beller <sbeller@google.com>
Date: May 26, 2015, 22:20 UTC
Message-ID: <CAGZ79ka6VOHpOcJ8Y_3DHApJoK=3msc6DigA6aOVxXYVHdB2Sg@mail.gmail.com>
In-Reply-To: <xmqqa8wrj85e.fsf@gitster.dls.corp.google.com>

On Tue, May 26, 2015 at 3:17 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>>
>> pack-protocol.txt says so and fetch-pack also follows it even though
>> upload-pack is a bit lax. Fix it.
>
> Hmm, I actually think the .txt file unsuccessfully tried to close
> the barn door after horse has long left.  The existing clients that
> read protocol capabilities keep the last-read copy and then
> overwrite it when a new one came, which is why we couldn't update
> the protocol by sending only incremental changes, etc. without
> breaking existing clients.

On the other hand I am not aware of any remote implementation handing out capabilities after the first line, so this would not break anything to my knowledge.

>
> I somehow thought that we already discussed why this was bad the
> first time Duy's patch was posted, but apparently we didn't.

/me checks the archive. I may have overlooked that part. :(

>
> X-<.