Re: [RFC/WIP PATCH 02/11] upload-pack: only accept capabilities on the first "want" line

From: Junio C Hamano <gitster@pobox.com>
Date: May 26, 2015, 22:17 UTC
Message-ID: <xmqqa8wrj85e.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1432677675-5118-3-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>
> pack-protocol.txt says so and fetch-pack also follows it even though
> upload-pack is a bit lax. Fix it.

Hmm, I actually think the .txt file unsuccessfully tried to close the barn door after horse has long left. The existing clients that read protocol capabilities keep the last-read copy and then overwrite it when a new one came, which is why we couldn't update the protocol by sending only incremental changes, etc. without breaking existing clients.

I somehow thought that we already discussed why this was bad the first time Duy's patch was posted, but apparently we didn't.

X-<.