Re: [RFC/WIP PATCH 11/11] Document protocol version 2

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 4, 2015, 17:01 UTC
Message-ID: <xmqq3827wgpz.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150604131852.GB12404@peff.net>

Jeff King <peff@peff.net> writes:

> We should definitely _not_ add anything that scales with the repository
> size. For instance, the "symref" field only shows the "HEAD" now. That's
> OK, as it's constant size.

I agree that this is an easy-to-explain rule to keep the design sensible.

> We do not show _all_ symrefs right now
> because of pkt-line length limitations. With v2, we could in theory
> start doing so (one per pkt-line). But that does not make it a good
> idea.

Very true. If we want symref information conveyed, then we should either make a new "symref advertisement" available (and it is OK to use a single-bit capability to enable or disable that new section), or make the "ref advertisement" natively capable of always doing so (i.e. if there is no need to make this optional).