From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 26 May 2015 22:21:37 GMT
Subject: Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number
Message-ID: <xmqq1ti3j7ym.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1432677675-5118-9-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> +	if (transport->smart_options
> +	    && transport->smart_options->transport_version) {
> +		buf = xmalloc(strlen(remote_program) + 12);
> +		sprintf(buf, "%s-%d", remote_program,
> +			transport->smart_options->transport_version);
> +		remote_program = buf;
> +	}

Bikeshedding: so the versioning scheme is that the current one is
zero, and the next one is two?  I would have expected that there
would be something like

	if (...->version < 2) {
        	... append "-%d" ...
	}

involved.