Re: [PATCH v3 2/8] doc: revisions - name the Left and Right sides

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 12, 2016, 16:47 UTC
Message-ID: <xmqq1t2y7qi8.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160711202518.532-3-philipoakley@iee.org>

Philip Oakley <philipoakley@iee.org> writes:

> The terms Left and Right side originate from the symmetric
> difference. Name them there.
> ---

Sign-off?

Show 13 quoted lines

>  Documentation/revisions.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/revisions.txt b/Documentation/revisions.txt
> index 19314e3..79f6d03 100644
> --- a/Documentation/revisions.txt
> +++ b/Documentation/revisions.txt
> @@ -256,7 +256,7 @@ A similar notation 'r1\...r2' is called symmetric difference
>  of 'r1' and 'r2' and is defined as
>  'r1 r2 --not $(git merge-base --all r1 r2)'.
>  It is the set of commits that are reachable from either one of
> -'r1' or 'r2' but not from both.
> +'r1' (Left side) or 'r2' (Right side) but not from both.

I think it is a good idea to call them explicitly left and right, but I do not think they need to be capitalized here or on the title of the patch.

>  In these two shorthands, you can omit one end and let it default to HEAD.
>  For example, 'origin..' is a shorthand for 'origin..HEAD' and asks "What