Re: [PATCH v2 4/4] doc: clarify that `^r1` will exclude `r1` itself
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 1, 2016, 22:14 UTC
- Message-ID
- <CAPc5daW_Kf8UG2zm4vBS9f4tN+bXusdZQkcwnssNs+gdk8J75w@mail.gmail.com>
- In-Reply-To
- <38FAE374CD2D44EC9C86167F98953271@PhilipOakley>
On Fri, Jul 1, 2016 at 3:08 PM, Philip Oakley <philipoakley@iee.org> wrote:
Show 12 quoted lines
>>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> To exclude commits reachable from a commit, a prefix '{caret}'
>>> notation is used. E.g. '{caret}r1 r2' means commits reachable
>>> -from 'r2' but exclude the ones reachable from 'r1'.
>>> +from 'r2' but exclude 'r1' and those reachable from 'r1'.
>>
>> Well, if you have to spell that out, you'd want to spell out r2 side
>> too, no? That is,
>
> The clarification wasn't about what "reachable" means but about inclusivity,
> such as whether 0..4 would give 0,1,2,3,4 or would be 'off by one' and only
> give 1,2,3,4. And in this case it's the latter.Well, you have the same inclusivity issue on the opposite end, no? Is 0..4 a range with 0,1,2,3,4? 0,1,2,3? 1,2,3,4? or 1,2,3?
> Describing 'reachability' is a whole different kettle of fish, as you > highlight below, and would be separate from this patch.
I am not sure I agree. It all is about "is the endpoint included or not?".