BUG: indent-with-non-tab always on (was: Re: [PATCH v6 00/12] Update git revisions)

From: Marc Branchaud <marcnarc@xiplink.com>
Date: Aug 15, 2016, 16:55 UTC
Message-ID: <5eda6874-43c8-7383-bbb3-b482a388370d@xiplink.com>
In-Reply-To: <8191B8FB581F44AAA7E2467A845C7532@PhilipOakley>

On 2016-08-15 11:00 AM, Philip Oakley wrote:

Show 18 quoted lines

> From: "Marc Branchaud" <marcnarc@xiplink.com>
>> On 2016-08-12 07:45 PM, Philip Oakley wrote:
>>> These are the quick fixes to Marc's comments to patches 5,6,11,
>>> and a consequential change to 12.
>>>
>>> Only the changed patches are included.
>>
>> Looks good to me -- no further comments!
>>
>> However, I still don't understand why git says 11/12 has "indent with
>> spaces" problems.
>
> I'm guessing it's that the text is monospaced rather than tabbed, and
> it's flagging that.
>
> I'd noticed that it was highlighted in the Git gui (which I use to
> visualise both the diff, the message and the part after the three dashes
> at the same time).

Actually, it looks like an indent-with-non-tab problem, which is supposed to be off by default.

Git doesn't complain about the patch if I set
	core.whitespace = tabwidth=11
presumably because the patch uses 10 spaces to indent the offending lines.

But explicitly disabling that check with
	core.whitespace = -indent-with-non-tab
doesn't work.

Unfortunately, I don't have time today to track this down.

M.