Re: [PATCH v5 05/12] doc: revisions: extra clarification of <rev>^! notation effects

From: Marc Branchaud <marcnarc@xiplink.com>
Date: Aug 12, 2016, 14:39 UTC
Message-ID: <c3271034-8fc5-3e29-ea1a-1c543abc7c52@xiplink.com>
In-Reply-To: <20160812070749.2920-6-philipoakley@iee.org>

On 2016-08-12 03:07 AM, Philip Oakley wrote:

Show 19 quoted lines

> Signed-off-by: Philip Oakley <philipoakley@iee.org>
> ---
> new
> Cc: Jakub Narębski <jnareb@gmail.com>
> https://public-inbox.org/git/578E4F4A.2020708%40gmail.com/
> ---
>  Documentation/revisions.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/revisions.txt b/Documentation/revisions.txt
> index 3da0083..0b5044d 100644
> --- a/Documentation/revisions.txt
> +++ b/Documentation/revisions.txt
> @@ -281,7 +281,8 @@ for naming a set that is formed by a commit and its parent commits.
>
>  The 'r1{caret}@' notation means all parents of 'r1'.
>
> -'r1{caret}!' includes commit 'r1' but excludes all of its parents.
> +'r1{caret}!' notation includes commit 'r1' but excludes all of its parents.

This sentence should start with "The".

> +This is the single commit 'r1', if standalone.

That reads awkwardly to me.  Perhaps

	By itself, this notation denotes the single commit 'r1'.

M.