Re: [PATCH v3 7/8] doc: revisions - define `reachable`
- From
Philip Oakley <philipoakley@iee.org>
- Date
- Jul 12, 2016, 21:44 UTC
- Message-ID
- <27A6AC8B1E3B4C80B95AFF19CEF7A962@PhilipOakley>
- In-Reply-To
- <5784F53E.9040104@xiplink.com>
From: "Marc Branchaud" <marcnarc@xiplink.com>
Show 30 quoted lines
> On 2016-07-11 04:25 PM, Philip Oakley wrote: >> Do not self-define `reachable`, which can lead to misunderstanding. >> Instead define `reachability` explictly. >> >> Signed-off-by: Philip Oakley <philipoakley@iee.org> >> --- >> Documentation/revisions.txt | 14 ++++++++++---- >> 1 file changed, 10 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/revisions.txt b/Documentation/revisions.txt >> index 1c59e87..a3cd28b 100644 >> --- a/Documentation/revisions.txt >> +++ b/Documentation/revisions.txt >> @@ -237,10 +237,16 @@ SPECIFYING RANGES >> ----------------- >> >> History traversing commands such as `git log` operate on a set >> -of commits, not just a single commit. To these commands, >> -specifying a single revision with the notation described in the >> -previous section means the set of commits reachable from that >> -commit, following the commit ancestry chain. >> +of commits, not just a single commit. >> + >> +For these commands, >> +specifying a single revision, using the notation described in the >> +previous section, means the `reachable` set of commits of the given >> +commit. > > Better as "... means the set of commits `reachable` from the given > commit."
OK. The main aspect is show that 'reachable' is a specific term.
Show 7 quoted lines
> >> + >> +A commit's reachable set is the commit itself and the commits of >> +its ancestry chain. >> + > > s/of/in/
OK.
>
-- Philip