Re: [PATCH 1/9] git_config_set: fix off-by-two

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 30, 2018, 18:44 UTC
Message-ID: <nycvar.QRO.7.76.6.1803302042570.5026@qfpub.tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqefk14jlb.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Fri, 30 Mar 2018, Junio C Hamano wrote:

Show 10 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> 
> > I think if it's worth fixing it's worth testing for, a future change to
> > the config code could easily introduce a regression for this, and
> > particularly in this type of code obscure edge cases like this can point
> > to bugs elsewhere.
> 
> Yup.  "The port to my favourite platform is too slow, and everybody
> should learn to live with thin test coverage" would not be a good
> strategy in the longer run.

What would be a *really* good strategy is: "Oh, there is a problem! Let's acknowledge it and try to come up with a solution rather than a work-around".

EXPENSIVE_ON_WINDOWS is a symptom. Not a solution.

And you are actively hurting my ability to contribute, I hope you are aware of that.

Ciao, Dscho