Re: [PATCH 1/9] git_config_set: fix off-by-two

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 30, 2018, 19:16 UTC
Message-ID: <CACsJy8DFva4y_Am-ZBei=VWXi4OdA0Y9Hc4xx7BnOHzVZP5gTQ@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1803302046550.5026@qfpub.tvgsbejvaqbjf.bet>

On Fri, Mar 30, 2018 at 8:53 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> I think the best course of action would be to incrementally do away with
> the shell scripted test framework, in the way you outlined earlier this
> year. This would *also* buy us a wealth of other benefits, such as better
> control over the parallelization, resource usage, etc.

If you have not noticed, I'm a bit busy with all sorts of stuff and probably won't continue that work. And since it affects you the most, you probably have the best motive to tackle it ;-) I don't think complaining about slow test suite helps. And avoiding adding more tests because of that definitely does not help.

Show 5 quoted lines

> It would also finally make it easier to introduce something like "smart
> testing" where code coverage could be computed (this works only for C
> code, of course, not for the many scripted parts of core Git), and a diff
> could be inspected to discover which tests *really* need to be run,
> skipping the tests that would only touch unchanged code.

-- 
Duy