Re: [PATCH 4/9] t1300: remove unreasonable expectation from TODO

From: Jeff King <peff@peff.net>
Date: Mar 29, 2018, 19:52 UTC
Message-ID: <20180329195218.GE2939@sigill.intra.peff.net>
In-Reply-To: <5801f7529465b7dbdfbe3c105e2a8212c253ba0d.1522336130.git.johannes.schindelin@gmx.de>

On Thu, Mar 29, 2018 at 05:18:50PM +0200, Johannes Schindelin wrote:

Show 10 quoted lines

> In https://public-inbox.org/git/7vvc8alzat.fsf@alter.siamese.dyndns.org/
> a reasonable patch was made quite a bit less so by changing a test case
> demonstrating a bug to a test case that demonstrates that we ask for too
> much: the test case 'unsetting the last key in a section removes header'
> now expects a future bug fix to be able to determine whether a free-form
> comment above a section header refers to said section or not.
> 
> Rather than shooting for the stars (and not even getting off the
> ground), let's start shooting for something obtainable and be reasonably
> confident that we *can* get it.

As I said before, I'm fine with turning this test into something more realistic.

An obvious question is whether we should preserve the original unrealistic parts by splitting it: the realistic parts into one expect_failure (that we'd switch to expect_success by the end of this series), and then an unrealistic one to serve as a documentation of the ideal, with a comment explaining why it's unrealistic.

I doubt the "unrealistic" half would be serving much purpose though, so I'm OK to see it get eliminated here.

-Peff