Re: [PATCH 0/9] Assorted fixes for `git config` (including the "empty sections" bug)

From: Stefan Beller <sbeller@google.com>
Date: Mar 29, 2018, 17:58 UTC
Message-ID: <CAGZ79ka41uD7A_64kz5oyrhCBci+oXmDGEVc6mHWyQd7d9avAQ@mail.gmail.com>
In-Reply-To: <cover.1522336130.git.johannes.schindelin@gmx.de>

On Thu, Mar 29, 2018 at 8:18 AM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:

Show 15 quoted lines

> So what is the argument against this extra care to detect comments? Well, if
> you have something like this:
>
>         [section]
>                 ; Here we comment about the variable called snarf
>                 snarf = froop
>
> and we run `git config --unset section.snarf`, we end up with this config:
>
>         [section]
>                 ; Here we comment about the variable called snarf
>
> which obviously does not make sense. However, that is already established
> behavior for quite a few years, and I do not even try to think of a way how
> this could be solved.

By commenting out the key/value pair instead of deleting it. It's called --unset, not --delete ;)

Now onto reviewing the patches.

Stefan