Re: [PATCH 4/4] git-imap-send: Add method to convert from LF to CRLF

From: Jakub Narebski <jnareb@gmail.com>
Date: Feb 9, 2010, 16:15 UTC
Message-ID: <m31vgu9yjk.fsf@localhost.localdomain>
In-Reply-To: <1265717345-2118-5-git-send-email-mitake@dcl.info.waseda.ac.jp>

Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> writes:

Show 10 quoted lines

> Some strict IMAP servers (e.g. Cyrus) don't
> allow "bare newlines ('\n')" in messages.
> So I added new boolean option "lf-to-crlf" to imap section.
> If this option enabled, git-imap-send converts LF to CRLF("\r\n").
> 
> If you want to use it, add line:
> 	lf-to-crlf
> to [imap] section of your .gitconfig .
> 
> This patch also adds description to Documentation/git-imap-send.txt .

Show 5 quoted lines

> +imap.lf-to-crlf::
> +	If you use strict IMAP server (e.g. Cyrus),
> +	"bare newlines ('\n')" in messages are not allowed.
> +	If this option enabled, git-imap-send converts LF to CRLF("\r\n").
> +

If you take a look at Documentation/config.txt at the names of other config variables, you would see that they have

  core.fileMode::
  core.ignoreCygwinFSTricks::
  core.quotepath::
  core.safecrlf::

names, i.e. either camelCase or allsmallcase, and not

  imap.lf-to-crlf::

with '-' to separate parts. Values can and do use this syntax, like e.g. `blank-at-eol` for core.whitespace.

The only outlier is add.ignore-errors (not add.ignoreerrors or add.ignoreErrors).

The same is true for the other config variable you propsed in 3/4 patch.

-- 
Jakub Narebski
Poland
ShadeHawk on #git