Re: [PATCH 4/4] git-imap-send: Add method to convert from LF to CRLF
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 9, 2010, 18:20 UTC
- Message-ID
- <7vbpfye0e5.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <alpine.LFD.2.00.1002090918180.3829@localhost.localdomain>
Linus Torvalds <torvalds@linux-foundation.org> writes:
> So I suspect that CRLF should be unconditional.
That matches my reading of the RFC. Thanks.
Hitoshi, can we have a modified version of 4/4 as a separate patch, so that we can apply it independently from the rest of the series?
As to the MD5 implementation, I am somewhat torn.
Even if your md5 implementation were vastly superiour and faster than OpenSSL one (I don't know), the use of MD5 is not performance critical like SHA-1 is (for which we uniformly use Linus's block SHA-1 these days); the only thing it would be buying us to have our own implementation is one less dependency for people who do want to use imap-send with CRAM-MD5 but without SSL support. How common is that combination?