Re: [PATCH v4 1/2] git-imap-send: Add CRAM-MD5 authenticate method support

> Hitoshi Mitake<mitake@dcl.info.waseda.ac.jp>  writes:
>
>> Because strlen(challenge_64) is the upper limit of length of challenge.
>> So tail part of challenge may not be filled by EVP_DecodeBlock(),
>> non-zero filled buffer produces not NULL terminated string.
>> I've confused once by this problem before.
>
> If you know the length of the decoded thing, then you would just know
> how much to hash.  Doesn't the EVP_DecodeBlock() give you that number?
> Why do you need a NUL termination to begin with?
>
> Because you pretend as if you do not have the actual length, you run
> strlen() instead.  I am not that familiar with the API to EVP_* functions,
> but I'd be surprised if it were designed in such a stupid way to force you
> to write into a pre-zeroed buffer.