Re: imap.preformattedHTML and imap.sslverify

From: Jeremy White <jwhite@codeweavers.com>
Date: Feb 8, 2010, 22:31 UTC
Message-ID: <4B7090C7.4040700@codeweavers.com>
In-Reply-To: <7v7hqqxj10.fsf@alter.siamese.dyndns.org>

Hi Junio,

>            [imap]
>                 sslverify = True

*blush* - I never looked at the parsing rules; = True, or = 1 would have seemed fine to me. I blame Rob. He led me astray. That's my story, and I'm sticking to it <grin>.

>  - The config parser downcases the key before calling the parse callback
>    function, so !strcmp("preformattedHTML", key) will never trigger.

Um...the patch I submitted used the (admittedly badly named) key 'html':
  http://marc.info/?l=git&m=123445427011604&w=2

I'm guessing that you changed it to preformattedHTML prior to committing;
that was something we discussed:
  http://marc.info/?l=git&m=123453315529656&w=2

So I think I can claim 'not guilty!' on that one (but only that one :-/).

> Could peole _test_ this patch and report, as I don't use this program at
> all.

I did confirm that your patch does work.

However, I assumed that my original patch was rejected. I never realized that it had been applied.

That clearly means that no one has ever used this option.

I'll remain unhurt if you revert it (c64d84f1452ec56fd1586493a0b0707bf7442c42), but let me know if you choose to apply your patch instead; I'll make a point to use it.

Cheers,

Jeremy