Re: [PATCH 4/4] git-imap-send: Add method to convert from LF to CRLF

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Feb 9, 2010, 17:24 UTC
Message-ID: <alpine.LFD.2.00.1002090918180.3829@localhost.localdomain>
In-Reply-To: <1265717345-2118-5-git-send-email-mitake@dcl.info.waseda.ac.jp>

On Tue, 9 Feb 2010, Hitoshi Mitake wrote:

Show 9 quoted lines

>
> Some strict IMAP servers (e.g. Cyrus) don't
> allow "bare newlines ('\n')" in messages.
> So I added new boolean option "lf-to-crlf" to imap section.
> If this option enabled, git-imap-send converts LF to CRLF("\r\n").
> 
> If you want to use it, add line:
> 	lf-to-crlf
> to [imap] section of your .gitconfig .

Hmm. Should this even be an option? Maybe we should _always_ do CRLF. That does seem to be the technically correct thing to do for SMTP and IMAP.

rfc2822 (smtp) is pretty clear that CRLF is the line ending, and neither CR nor LF must ever be sent individually. That's true both for headers and the body of the email. The same goes for rfc3501 (imap).

So I suspect that CRLF should be unconditional.

		Linus