Re: [PATCH v2 1/2] git-imap-send: Add CRAM-MD5 authenticate method support
- From
Erik Faye-Lund <kusmabite@googlemail.com>
- Date
- Feb 11, 2010, 14:55 UTC
- Message-ID
- <40aa078e1002110655n120b14b9y242a57d0e1bd3e96@mail.gmail.com>
- In-Reply-To
- <1265899135-11488-1-git-send-email-mitake@dcl.info.waseda.ac.jp>
On Thu, Feb 11, 2010 at 3:38 PM, Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:
Show 24 quoted lines
> @@ -1101,6 +1190,7 @@ static struct store *imap_open_store(struct imap_server_conf *srvc)
> }
> #endif
> imap_info("Logging in...\n");
> +
> if (!srvc->user) {
> fprintf(stderr, "Skipping server %s, no user\n", srvc->host);
> goto bail;
> @@ -1258,6 +1375,7 @@ static int read_message(FILE *f, struct msg_data *msg)
>
> msg->len = buf.len;
> msg->data = strbuf_detach(&buf, NULL);
> +
> return msg->len;
> }
>
> @@ -1307,21 +1425,10 @@ static int split_msg(struct msg_data *all_msgs, struct msg_data *msg, int *ofs)
>
> msg->data = xmemdupz(data, msg->len);
> *ofs += msg->len;
> +
> return 1;
> }
>There's not much point in having three hunks with a single added newline in each...
-- Erik "kusma" Faye-Lund