Re: [RFC PATCH 1/5] builtin/checkout: avoid usage of '!!'

From: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
Date: Sep 20, 2017, 11:26 UTC
Message-ID: <fbe3d3e2-a14c-fe7c-7e5d-c24789b249ca@gmail.com>
In-Reply-To: <e07a613e-8b69-e382-777b-b5797270ecaf@gmail.com>

Wait, I missed a contradiction here.

On Wednesday 20 September 2017 09:30 AM, Junio C Hamano wrote:

> ....  And !!ptr is a shorter and more established way than ptr
> != NULL to turn non-NULL ness into an int boolean,

Documentation/SubmittingPatches says:

>  - Some clever tricks, like using the !! operator with arithmetic
>    constructs, can be extremely confusing to others.

If !!ptr is a **more established way** to then why should it confuse others. Of course, !!ptr was stated as an "exception-rule" where ptr is a pointer (possibly NULL). That makes me wonder in what case is it "confusing" at all?

--- Kaartic

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.