Re: [RFC PATCH v3 3/4] branch: introduce dont_fail parameter for branchname validation
- From
Stefan Beller <sbeller@google.com>
- Date
- Nov 2, 2017, 18:42 UTC
- Message-ID
- <CAGZ79kY-1PLf2aOeNOkPz_MNSPtJHTtj=9eC-xdbbLq+WZbkwg@mail.gmail.com>
- In-Reply-To
- <e8a600d4-880b-4fb8-6901-78acbd720261@gmail.com>
On Thu, Nov 2, 2017 at 1:39 AM, Kaartic Sivaraam <kaartic.sivaraam@gmail.com> wrote:
Show 10 quoted lines
> On Thursday 02 November 2017 12:24 PM, Kaartic Sivaraam wrote: >> >> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> >> Signed-off-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> > > > I just now saw this small glitch as a consequence of recently > changing my email address. I would prefer to keep the second one > but as the other patches have the first one it's better to keep > the first one for now.
If you prefer one of them, you may have incentive to add an entry into .mailmap file, otherwise I'd kindly ask you to. :) (c.f. `git log --no-merges -- .mailmap`)
Show 7 quoted lines
> But wait, it seems that this commit also has a different author > identity (the email adress part). If this is a big enough issue, > I'll fix that and send a v4 (possibly with any other suggested > changes) else I'll leave it as it is. > > BTW, I added the Ccs to this mail which I forgot to do when > sending the patches, hope it's not an issue.