Re: [RFC PATCH v3 3/4] branch: introduce dont_fail parameter for branchname validation
- From
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
- Date
- Nov 3, 2017, 02:58 UTC
- Message-ID
- <2aba29d1-3c6c-f04d-b284-991dbe15be54@gmail.com>
- In-Reply-To
- <CAGZ79kY-1PLf2aOeNOkPz_MNSPtJHTtj=9eC-xdbbLq+WZbkwg@mail.gmail.com>
On Friday 03 November 2017 12:12 AM, Stefan Beller wrote:
Show 17 quoted lines
> On Thu, Nov 2, 2017 at 1:39 AM, Kaartic Sivaraam > <kaartic.sivaraam@gmail.com> wrote: >> On Thursday 02 November 2017 12:24 PM, Kaartic Sivaraam wrote: >>> >>> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> >>> Signed-off-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> >> >> >> I just now saw this small glitch as a consequence of recently >> changing my email address. I would prefer to keep the second one >> but as the other patches have the first one it's better to keep >> the first one for now. > > If you prefer one of them, you may have incentive to > add an entry into .mailmap file, otherwise I'd kindly ask you > to. :) (c.f. `git log --no-merges -- .mailmap`) >
Sure, I'll do that. My intuition says this doesn't remove the duplicated sign-off line. Anyways, there's for sure a v4 that's going to update the connector string in [4/4] and another update. I'll be careful to address these issues in v4.
--- Kaartic