Re: [PATCH v4 2/3] builtin/branch: stop supporting the use of --set-upstream option
- From
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
- Date
- Aug 18, 2017, 02:41 UTC
- Message-ID
- <42219b51-8232-e1ee-9c48-f67ccdcbb4c8@gmail.com>
- In-Reply-To
- <xmqqshgqezox.fsf@gitster.mtv.corp.google.com>
On Friday 18 August 2017 01:25 AM, Junio C Hamano wrote:
Show 14 quoted lines
> Martin Ågren <martin.agren@gmail.com> writes: > >> On 17 August 2017 at 04:54, Kaartic Sivaraam >> <kaarticsivaraam91196@gmail.com> wrote: >>> Helped-by: Martin Ågren <martin.agren@gmail.com>, Junio C Hamano <gitster@pobox.com> >>> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> >> I didn't expect a "Helped-by", all I did was to give some random >> comments. :-) I'm not so sure about the comma-separation, that seems to >> be a first in the project. > I didn't either ;-) > > The line looks odd so I'll remove it while queuing. > > Thanks for noticing.
I should have been better with my wordings :) How about converting that line into two 'Suggestions-by:' or 'Reviewed-by:' ?
--- Kaartic