Re: [PATCH] gitweb: Do not print "log" and "shortlog" redundantly in commit view

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 6, 2006, 07:44 UTC
Message-ID: <eg51fi$7rs$2@sea.gmane.org>
In-Reply-To: <20061005192257.50209.qmail@web31809.mail.mud.yahoo.com>

Luben Tuikov wrote:

Show 8 quoted lines

> Do not print "log" and "shortlog" redundantly in commit
> view.  This is passed into the $extra argument of
> git_print_page_nav from git_commit, but git_print_page_nav
> prints "log" and "shortlog" already with the same head.
> 
> Noticed by Junio.
> 
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>

Gaah, the whole cae1862a3b55b487731e9857f2213ac59d5646d commit "gitweb: More per-view navigation bar links" is somewhat broken. Up to this point we used top navigation bar for commit (hash base) or whole project related links, while bottom part of navigation bar for "formats" i.e. links related to current view (passing hash) or for pagination.

So while "snapshot" link has it's place in top navigation bar
(but by modyfying git_print_page_nav subroutine, not by adding it
by hand), "history" for example IMHO doesn't; history link should be
present in the bottom part of navigation bar. Perhaps we could
reuse git_print_page_nav for formats, for example blob wiew would have
        blob | _blame_ | _history_ | _raw_ | _HEAD_
while tree view would have
        tree | _snapshot_ | _history_ | _HEAD_
(where _text_ indices link).  Perhaps _snapshot_ in tree view
shouldn't be repeated, although top one might mean snapshot of commitish,
bottom one snapshot of tree.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git