Re: [PATCH 2/2] gitweb: Show trailing slash when listing tree entry in tree listing

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Oct 10, 2006, 22:18 UTC
Message-ID: <20061010221853.98520.qmail@web31807.mail.mud.yahoo.com>
In-Reply-To: <200610102313.48170.jnareb@gmail.com>

--- Jakub Narebski <jnareb@gmail.com> wrote:

Show 17 quoted lines

> Dnia wtorek 10. paï¿½dziernika 2006 23:02, Luben Tuikov napisaï¿½:
> > > > Isn't that a simple "labelling" question? ï¿½I do not think
> > > > anybody minds to show clickable string "contents" (instead of
> > > > "blob" or "tree") at the places you mention above and if we did
> > > > so everybody would be happy, right?
> > > 
> > > Not, IMHO it is not a good idea. Clicking on file name leads to it
> > > contents, but it is not obvoius what kind of view is it. "blob" link
> > 
> > It is pretty obvious to me: the contents of the object, whether it be
> > "blob" or "tree". ï¿½The contents of "blob" and the contents of "tree"
> > as shown by gitweb.
> 
> It's pretty obvous to you, because there is only one basic view of tree, 
> and one basic view of blob. It is not the case for example for commits 
> in shortlog view, where we have commit and commitdiff views. It is 
> possible that either blobs or trees acquire another views.

Excuse me, weren't we talking about "blob" and "tree"?

How come you all of a sudden introduce commits? Let's keep on topic: "blob" and "tree".

   Luben